Add option to ChipTool to allow session setup for large payloads.

By default, assumed false. When set to 1, it will trigger an attempt to set up a session over TCP to support large payload transfers. E.g., ./chip-tool onoff read on-off 15 2 --allow-large-payload 1 Fixes project-chip#29697
pidarped · Jun 14, 2024 · 78d5856 · 78d5856
1 parent 60ae46d
commit 78d5856
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/examples/chip-tool/commands/clusters/ModelCommand.cpp b/examples/chip-tool/commands/clusters/ModelCommand.cpp
@@ -44,8 +44,12 @@ CHIP_ERROR ModelCommand::RunCommand()
         return SendCommand(commissioneeDeviceProxy, mEndPointId);
     }
 
+    // Check if the session needs to allow large payload support.
+    TransportPayloadCapability transportPayloadCapability = AllowLargePayload() ? TransportPayloadCapability::kLargePayload :
+                                                            TransportPayloadCapability::kMRPPayload;
     return CurrentCommissioner().GetConnectedDevice(mDestinationId, &mOnDeviceConnectedCallback,
-                                                    &mOnDeviceConnectionFailureCallback);
+                                                    &mOnDeviceConnectionFailureCallback,
+                                                    transportPayloadCapability);
 }
 
 void ModelCommand::OnDeviceConnectedFn(void * context, chip::Messaging::ExchangeManager & exchangeMgr,
@@ -134,3 +138,15 @@ bool ModelCommand::IsPeerLIT()
     CheckPeerICDType();
     return mIsPeerLIT.ValueOr(false);
 }
+
+bool ModelCommand::AllowLargePayload()
+{
+    if (mAllowLargePayload.HasValue())
+    {
+        return (mAllowLargePayload.Value());
+    }
+    else
+    {
+        return false;
+    }
+}
diff --git a/examples/chip-tool/commands/clusters/ModelCommand.h b/examples/chip-tool/commands/clusters/ModelCommand.h
@@ -57,6 +57,8 @@ class ModelCommand : public CHIPCommand
             "Whether to treat the peer as a LIT ICD. false: Always no, true: Always yes, (not set): Yes if the peer is registered "
             "to this controller.");
         AddArgument("timeout", 0, UINT16_MAX, &mTimeout);
+        AddArgument("allow-large-payload", 0, 1, &mAllowLargePayload,
+                    "Indicates if the session should allow large application payloads. When true, the controller tries to establish a secure session over TCP. Otherwise session is established over MRP. Assumed to be false when not specified.");
     }
 
     /////////// CHIPCommand Interface /////////
@@ -82,9 +84,12 @@ class ModelCommand : public CHIPCommand
     chip::NodeId mDestinationId;
     std::vector<chip::EndpointId> mEndPointId;
     chip::Optional<bool> mIsPeerLIT;
+    chip::Optional<bool> mAllowLargePayload;
 
     void CheckPeerICDType();
 
+    bool AllowLargePayload();
+
     static void OnDeviceConnectedFn(void * context, chip::Messaging::ExchangeManager & exchangeMgr,
                                     const chip::SessionHandle & sessionHandle);
     static void OnDeviceConnectionFailureFn(void * context, const chip::ScopedNodeId & peerId, CHIP_ERROR error);