ACAN_ESP32: Add ACAN_ESP32::end() to stop the controller and remove ISR #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some applications require stopping the controller (at least temporarily) for example when starting the OTA process as, during that, getting any interrupt from the CAN controller may be not desirable, as that could be increasing the likeliness of an OTA failure (and noone wants to end up with a corrupt flash). The OTA case is just one of the possible examples, anyway. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
celodex
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications require stopping the controller (at least temporarily) for example when starting the OTA process as, during that, getting any interrupt from the CAN controller may be not desirable, as that could be increasing the likeliness of an OTA failure (and noone wants to end up with a corrupt flash).
The OTA case is just one of the possible examples, anyway.
This was tested on ESP32-S3R8 and S3R2.