Optionally disable MCP2517FD workarounds #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fterretf
added a commit
to fterretf/acan2517FD
that referenced
this pull request
Jun 2, 2023
fterretf
added a commit
to fterretf/acan2517FD
that referenced
this pull request
Jun 7, 2023
fterretf
added a commit
to fterretf/acan2517FD
that referenced
this pull request
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default this does nothing, when enabling the compile-time-define DISABLEMCP2517FDCOMPAT it no longer disables interrupts during SPI transactions which slightly increases performance and avoids delaying interrupts (which could be problematic on dimmers for example as they may start flickering).
I took this chance to move the duplicate enable/disable code to it's own function that is always inlined, so this just improved readability but shouldn't affect the generated machine code at all.
This new option should be added to the documentation PDF aswell.
Fixes: #26