Update to set explicit SPI frequency #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich has too high default frequency
|
I can confirm that without this change the piface isn't detected, and the patch fixes it. What I couldn't find was the value used before: I cannot confirm that 100000 is the best value to use. 10000 also seems to work (typo), as does 15000 (as suggested here: https://www.raspberrypi.org/forums/viewtopic.php?t=196248). |
|
Yeah looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer kernels 4.1.+ the default SPI frequency is set to the theoretical maximum based on the clock. This will also become the default frequency unless set specifically.
Since the current code does not set frequency explicit the pifacecaad will not work since the freq is far too high. This patch sets the frequency back to 100kHz and hence allows the board to work with newer kernels.