Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity picture #146

Closed
chertvl opened this issue Feb 20, 2022 · 4 comments · Fixed by #393
Closed

Entity picture #146

chertvl opened this issue Feb 20, 2022 · 4 comments · Fixed by #393
Labels
enhancement New feature or request

Comments

@chertvl
Copy link

chertvl commented Feb 20, 2022

Is your feature request related to a problem? Please describe.
Is it possible to make a feature that allows you use entity pictures in cards?
For example, I have several template sensors with .png pictures instead of icons.
Better if we could set image path in card setting, as it realized in custom -button-card.

Thanks!

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@chertvl chertvl added the enhancement New feature or request label Feb 20, 2022
@piitaya
Copy link
Owner

piitaya commented Feb 20, 2022

It's a duplicate of #100. We don't plan to support png or svg image for now because it's not standard for HA entity. It's only supported by person card because the person entity is the entity only with image support.

@piitaya piitaya added wontfix This will not be worked on and removed enhancement New feature or request labels Feb 20, 2022
@chertvl
Copy link
Author

chertvl commented Feb 20, 2022

I would like to argue. Set png as entity icon its HA default feature (customize docs).
And we can see this custom icon everywhere - logbook, more-info, etc, but not in the Mushroom cards.
image
image

@piitaya
Copy link
Owner

piitaya commented Feb 20, 2022

Thank for the explanation 😊. I didn't known it was possible to do that.
I think we need to refactor the components before because adding new options will duplicate a lot of code.

@piitaya piitaya added enhancement New feature or request and removed wontfix This will not be worked on labels Feb 20, 2022
@brandensilva
Copy link

Neat, I didn't know that was possible either. I'd love to do a custom set of icons for entities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants