Entity picture option to chip entity card #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Loved this project and wanted to contribute. Don't want to be rude and understand people have other things to do. But 12 days now and no response from anyone. Lot of other PR that is later that have more activity. Seems that my help is not welcome or I'm doing something wrong? Have other PR with no response either. |
|
Sorry for the late reply. I think it's a good idea. Maybe we can use a size in |
|
this is what i was asking about. |
|
I merge the PR and will add entity_picture to entity card too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to show the entity picture instead of icon in the chip entity card.
Increased image size to 24px instead of 1.5em that icons was. 1.5em image seemed to be very small.
Feel free to review and comment it.