Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spacing between chips #1458

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Improve spacing between chips #1458

merged 1 commit into from
Jul 6, 2024

Conversation

riesinger
Copy link
Contributor

@riesinger riesinger commented Jul 5, 2024

Description

This patch uses the gap property instead of margins on the chip cards container, which fixes some alignment bugs in some cases

Before:
image

After:
image

Related Issue

This PR fixes or closes issue: fixes #1459

Motivation and Context

This solves the problem of misaligned chips in some cases.

How Has This Been Tested

By visually checking this in my dev instance.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

This patch uses the `gap` property instead of margins on the chip cards container, which fixes some alignment bugs in some cases
@riesinger riesinger marked this pull request as ready for review July 5, 2024 11:21
Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@piitaya piitaya merged commit 198bc10 into piitaya:main Jul 6, 2024
1 check passed
@piitaya piitaya added the bug Something isn't working label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Chips spacing weird in some cases
2 participants