Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vertical stack and ha-card #417

Merged
merged 1 commit into from
Apr 30, 2022
Merged

fix: vertical stack and ha-card #417

merged 1 commit into from
Apr 30, 2022

Conversation

acesyde
Copy link
Contributor

@acesyde acesyde commented Apr 29, 2022

Description

  • ha-card node must be at the top just before the first shadow root element
  • Fix incompatibility with vertical-stack-card

Related Issue

#415

Motivation and Context

How Has This Been Tested

All cards tested one by one and with vertical-stack-card

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@piitaya piitaya merged commit 31a4016 into piitaya:main Apr 30, 2022
@piitaya piitaya added the bug Something isn't working label Apr 30, 2022
@bramstroker bramstroker mentioned this pull request May 1, 2022
Merged
8 tasks
@piitaya piitaya mentioned this pull request May 1, 2022
Closed
@acesyde acesyde deleted the fix/vertical_stack branch May 13, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piitaya piitaya piitaya approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acesyde @piitaya