Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cards): use entity_picture_local when necessary #430

Merged
merged 1 commit into from
May 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/cards/chips-card/chips/entity-chip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { customElement, property, state } from "lit/decorators.js";
import { classMap } from "lit/directives/class-map.js";
import { styleMap } from "lit/directives/style-map.js";
import { computeStateDisplay } from "../../../ha/common/entity/compute-state-display";
import { isActive } from "../../../ha/data/entity";
import { getEntityPicture, isActive } from "../../../ha/data/entity";
import { computeRgbColor } from "../../../utils/colors";
import { actionHandler } from "../../../utils/directives/action-handler-directive";
import { stateIcon } from "../../../utils/icons/state-icon";
Expand Down Expand Up @@ -63,9 +63,7 @@ export class EntityChip extends LitElement implements LovelaceChip {
const icon = this._config.icon || stateIcon(entity);
const iconColor = this._config.icon_color;

const picture = this._config.use_entity_picture
? entity.attributes.entity_picture
: undefined;
const picture = this._config.use_entity_picture ? getEntityPicture(entity) : undefined;

const stateDisplay = computeStateDisplay(this.hass.localize, entity, this.hass.locale);

Expand Down
6 changes: 2 additions & 4 deletions src/cards/entity-card/entity-card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { customElement, state } from "lit/decorators.js";
import { classMap } from "lit/directives/class-map.js";
import { styleMap } from "lit/directives/style-map.js";
import { computeStateDisplay } from "../../ha/common/entity/compute-state-display";
import { isActive, isAvailable } from "../../ha/data/entity";
import { getEntityPicture, isActive, isAvailable } from "../../ha/data/entity";
import "../../shared/badge-icon";
import "../../shared/card";
import "../../shared/shape-avatar";
Expand Down Expand Up @@ -86,9 +86,7 @@ export class EntityCard extends MushroomBaseElement implements LovelaceCard {
const hideIcon = !!this._config.hide_icon;
const layout = getLayoutFromConfig(this._config);

const picture = this._config.use_entity_picture
? entity.attributes.entity_picture
: undefined;
const picture = this._config.use_entity_picture ? getEntityPicture(entity) : undefined;

const stateDisplay = computeStateDisplay(this.hass.localize, entity, this.hass.locale);

Expand Down
6 changes: 2 additions & 4 deletions src/cards/media-player-card/media-player-card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import { css, CSSResultGroup, html, PropertyValues, TemplateResult } from "lit";
import { customElement, state } from "lit/decorators.js";
import { classMap } from "lit/directives/class-map.js";
import { isActive } from "../../ha/data/entity";
import { getEntityPicture, isActive } from "../../ha/data/entity";
import { MediaPlayerEntity } from "../../ha/data/media-player";
import "../../shared/badge-icon";
import "../../shared/card";
Expand Down Expand Up @@ -144,9 +144,7 @@ export class MediaPlayerCard extends MushroomBaseElement implements LovelaceCard

const rtl = computeRTL(this.hass);

const artwork = this._config.use_media_artwork
? entity.attributes.entity_picture
: undefined;
const artwork = this._config.use_media_artwork ? getEntityPicture(entity) : undefined;

return html`
<ha-card class=${classMap({ "fill-container": this._config.fill_container ?? false })}>
Expand Down
6 changes: 2 additions & 4 deletions src/cards/person-card/person-card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { css, CSSResultGroup, html, TemplateResult } from "lit";
import { customElement, state } from "lit/decorators.js";
import { classMap } from "lit/directives/class-map.js";
import { styleMap } from "lit/directives/style-map.js";
import { isActive, isAvailable } from "../../ha/data/entity";
import { getEntityPicture, isActive, isAvailable } from "../../ha/data/entity";
import "../../shared/badge-icon";
import "../../shared/card";
import "../../shared/shape-avatar";
Expand Down Expand Up @@ -82,9 +82,7 @@ export class PersonCard extends MushroomBaseElement implements LovelaceCard {
const name = this._config.name || entity.attributes.friendly_name;
const icon = this._config.icon || stateIconHelper(entity);

const picture = this._config.use_entity_picture
? entity.attributes.entity_picture
: undefined;
const picture = this._config.use_entity_picture ? getEntityPicture(entity) : undefined;

const layout = getLayoutFromConfig(this._config);
const hideState = !!this._config.hide_state;
Expand Down
6 changes: 2 additions & 4 deletions src/cards/update-card/update-card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { classMap } from "lit/directives/class-map.js";
import { styleMap } from "lit/directives/style-map.js";
import { computeStateDisplay } from "../../ha/common/entity/compute-state-display";
import { supportsFeature } from "../../ha/common/entity/supports-feature";
import { isActive, isAvailable } from "../../ha/data/entity";
import { getEntityPicture, isActive, isAvailable } from "../../ha/data/entity";
import { UpdateEntity, updateIsInstalling, UPDATE_SUPPORT_INSTALL } from "../../ha/data/update";
import "../../shared/badge-icon";
import "../../shared/card";
Expand Down Expand Up @@ -85,9 +85,7 @@ export class UpdateCard extends MushroomBaseElement implements LovelaceCard {

const name = this._config.name || entity.attributes.friendly_name || "";
const icon = this._config.icon || stateIcon(entity);
const picture = this._config.use_entity_picture
? entity.attributes.entity_picture
: undefined;
const picture = this._config.use_entity_picture ? getEntityPicture(entity) : undefined;

const layout = getLayoutFromConfig(this._config);

Expand Down
7 changes: 7 additions & 0 deletions src/ha/data/entity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,10 @@ export function isOff(entity: HassEntity) {
export function isUnknown(entity: HassEntity) {
return entity.state === UNKNOWN;
}

export function getEntityPicture(entity: HassEntity) {
return (
(entity.attributes.entity_picture_local as string | undefined) ||
entity.attributes.entity_picture
);
}