Fix strict error handling in templates #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that 👍 |
ulic75
added a commit
to ulic75/lovelace-mushroom
that referenced
this pull request
May 12, 2022
* Update Vietnamese translation (piitaya#448) * Update vi.json * Change "Chip" to "chip" * feat(humidifier): add humidifier support (piitaya#346) * feat(humidifier): card * feat(humidifier): improve card * fix: view name * fix: humidity live * fix: MushroomBaseElement * fix: clean unused dependencies * fix: hacard * fix: collapsible controls * fix: remove buttons control * fix: remove buttons control * fix(humidifier): some fixes (piitaya#451) * fix: remove console.log * feat(media-player): show volume next to state when not unavailable/unknown/off (piitaya#374) * Show volume next to state * Revert "Show volume next to state" This reverts commit c40e32f. Undo due to suggestion from @acesyde * Reworked volume state based on feedback Co-authored-by: Paul Bottein <paul.bottein@gmail.com> * feat(media-player): add option to display volume level (piitaya#452) * chore: bump deps (piitaya#453) * 1.8.0 * Update README.md * Update German translation (piitaya#458) * Update de.json * Update de.json * Update de.json * Update zh-Hant.json (piitaya#455) * Update alarm card documentation according to piitaya#376 (piitaya#459) * Allow customizing badge, button, shape, slider sizes (piitaya#464) * Allow customizing badge, button, shape, slider sizes * Add --shape-avatar-size * feat(themes): improve css variables (piitaya#466) * fix(chip): fix avatar size for chip * fix(chip): add avatar only support (piitaya#468) * fix(actions): allow scroll within actions (piitaya#469) * Fix strict error handling in templates (piitaya#472) * Update German translation (piitaya#474) * Update de.json * Update de.json * Update de.json * Update de.json * 1.8.1 * Update README to reflect recent UI changes in HA 2022.5 (piitaya#470) * fix(ios): fix button size on ios * 1.8.2 * Update Italian translation (piitaya#478) Added humidity control translation Added show volume translation * 1.8.3 * update for new css variables Co-authored-by: redphx <96280+redphx@users.noreply.github.com> Co-authored-by: Pierre-Emmanuel Mercier <acesyde@gmail.com> Co-authored-by: Paul Bottein <paul.bottein@gmail.com> Co-authored-by: madmurl0c <42262826+madmurl0c@users.noreply.github.com> Co-authored-by: steffenrapp <88974099+steffenrapp@users.noreply.github.com> Co-authored-by: rhuba8324 <53090204+rhuba8324@users.noreply.github.com> Co-authored-by: Julien Ehrhart <julien.ehrhart@live.com> Co-authored-by: Franck Nijhof <git@frenck.dev> Co-authored-by: Doryx <81909485+doryxbirb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes template rendering to let bubble up all template errors to the UI (instead of the Home Assistant logs), by marking the rendering as strict.
This prevents the Home Assistant logs to become, essentially, a keylogger; and also provides more feedback in the UI.
Reported and related to home-assistant/core#70259
Related Issue
Motivation and Context
See above
How Has This Been Tested
With bare hands
Types of changes
Checklist