Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spanish translation #484

Merged
merged 3 commits into from
May 16, 2022
Merged

Add Spanish translation #484

merged 3 commits into from
May 16, 2022

Conversation

AtomikWiWa
Copy link
Contributor

@AtomikWiWa AtomikWiWa commented May 14, 2022 •
edited
Loading

Description

Add Spanish translation

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@AtomikWiWa
Add Spanish translation
5df2830 
Add Spanish translation
oscfdezdz
oscfdezdz reviewed May 15, 2022
View reviewed changes
src/translations/es.json Outdated Show resolved Hide resolved
src/translations/es.json Outdated Show resolved Hide resolved
@oscfdezdz
Copy link
Contributor

Also, you need to import src/translations/es.json into src/localize.ts, as stated in README. For reference: 9d3c896.

AtomikWiWa and others added 2 commits May 15, 2022 19:23
@AtomikWiWa @oscfdezdz
Apply suggestions from code review
468d097 
Co-authored-by: Óscar Fernández Díaz <oscfdezdz@tuta.io>
@AtomikWiWa
Add spanish
42fff29
@piitaya piitaya added the translations Translations label May 16, 2022
@piitaya piitaya merged commit 7f7835c into piitaya:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscfdezdz oscfdezdz oscfdezdz left review comments

Assignees
No one assigned
Labels
translations Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AtomikWiWa @oscfdezdz @piitaya