Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): add card text line height variable #496

Merged
merged 1 commit into from
May 17, 2022
Merged

feat(theme): add card text line height variable #496

merged 1 commit into from
May 17, 2022

Conversation

piitaya
Copy link
Owner

@piitaya piitaya commented May 17, 2022 •
edited
Loading

Description

Line height was not the same between devices (mobile, desktop, cast). This PR fixes it and allow user to customize the line-height using theme.

Related Issue

Nop

Motivation and Context

How Has This Been Tested

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@piitaya piitaya added the enhancement New feature or request label May 17, 2022
@piitaya piitaya merged commit 54dcc28 into main May 17, 2022
@piitaya piitaya deleted the feat/card-line-height branch May 17, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@piitaya