Minor debug cleanup #1099
Merged
Minor debug cleanup #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hides the namespace use and cleans up a number of otherwise useless using namespace declarations for anything inside one of the debug macros
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
msimberg
reviewed
Apr 19, 2024
libs/pika/async_mpi/tests/unit/mpi_ring_async_sender_receiver.cpp
Outdated
Show resolved
Hide resolved
biddisco
force-pushed
the
minor_debug_cleanup
branch
from
03f2a99
to
f3cfed4
Compare
|
Added one clang format patch since I had to reformat my stuff and noticed there's a mismatch in in versions in scripts |
msimberg
reviewed
Apr 22, 2024
msimberg
approved these changes
Apr 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 1 : Simplifies the debug helper code by removing ifdefs and using
__has_includefor c++ name demmanglingpart 2 : declutter some of the mpi code for example by moving a namespace check into a macro so it doesn't need to be used in many places.
pushing this PR because it is in my incoming MPI change PR and can be reviewed separately
Note that removing the debug code and replacing it with
fmt::is a next step.