binance: use built-in anext() add note about new ws ep URL, fix agen streaming within NoBsWs usage
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
added
integration
|
Ahh shoot, i guess you have to checkout and uncomment the other ep url line 😂 here's their docs on this: https://developers.binance.com/docs/binance-trading-api/websocket_api#general-api-information no idea what's up, but obviously as per this patch, we were using |
goodboy
force-pushed
the
binance_ws_ep_update
branch
from
83c3dcc
to
32eeb2e
Compare
goodboy
force-pushed
the
binance_ws_ep_update
branch
from
32eeb2e
to
78eb784
Compare
goodboy
changed the title
binance: use built-in anext() add note about new ws ep URLbinance: use built-in anext() add note about new ws ep URL, fix agen streaming within NoBsWs usage
goodboy
changed the title
binance: use built-in anext() add note about new ws ep URL, fix agen streaming within NoBsWs usagebinance: use built-in anext() add note about new ws ep URL, fix agen streaming within NoBsWs usage
Apparently it will likely fix our `trio`-cancel-scopes-corrupted crash when we try to let our `._web_bs.NoBsWs` do reconnect logic around the asyn-generator implemented data-feed streaming routines in `binance` and `kraken`. See the project docs for deatz; obvs we add the lib as a dep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this ain't workin for me (but maybe someone else can test
to verify?) but I tried updating the latest documented WS endpoint and
it doesn't seem to ever work 😂
Further this starts using the new built-in
anext()routines instead ofthe dunders we had to use prior.
ALSO
updates the streamer async-gen with anaclosing()which issuper critical to avoid
triocrashes on re-connection logic!INSTEAD uses
@trio_util.trio_async_generatorwhich actuallysolves the underlying issue of allowing an agen to work through multiple
cancel scopes as is needed by our
NoBsWsreconnection logic.. => in 609b91e