Fix resource leak in listening thread. #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thread launched to listen on the socket while the nscd request is processed was being written to a temporary thread_t. This means the thread couldn't be pthread_join'd, which is what would release its resources (which includes the memory allocated for the thread's stack), and this allocation would live on until nscd is killed. To avoid having to control the thread lifetime, we can simply pthread_detach it, which makes it so returning from the thread function releases its resources. This commit fixes an issue where practically each new nscd request would add (thread stack size + guard page size) bytes to the memory in use by nscd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thread launched to listen on the socket while the nscd request is
processed was being written to a temporary thread_t. This means the
thread couldn't be pthread_join'd, which is what would release its
resources (which includes the memory allocated for the thread's stack),
and this allocation would live on until nscd is killed. To avoid having
to control the thread lifetime, we can simply pthread_detach it, which
makes it so returning from the thread function releases its resources.
This commit fixes an issue where practically each new nscd request would
add (thread stack size + guard page size) bytes to the memory in use by
nscd.