Decrease initial memory allocation for passwd and grp buffers #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of querying sysconf once per loop for a value, we should just store it during initialization, since it's environment information whose value won't change during runtime. Even so, since most of the time we are on musl, this function always returns -1 and we end up using the BUF_LEN_DEFAULT buffer size. For now, actually using these buffer lengths isn't implemented, because the code that uses them is being refactored.
Move BUF_LEN_DEFAULT's value to the one used by glibc in their headers.
musl (as of version 1.2.2) defines NGROUPS_MAX to 32, but glibc and the kernel define it to 65536. Since musl might change the definition at some point, and the nss_initgroups interface allows the callee to realloc the buffer, we don't have to allocate the maximum value upfront, and can keep using 32 as a reasonable initial default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in commit, we don't use the buffer lengths yet, because it will be part of the refactoring necessary to add caching.