Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash during 1.5 => 2.1 transition #87

Closed
martinbonnin opened this issue Sep 19, 2017 · 9 comments
Closed

crash during 1.5 => 2.1 transition #87

martinbonnin opened this issue Sep 19, 2017 · 9 comments
Assignees

Comments

@martinbonnin
Copy link
Contributor

I made a small android app to reproduce there: https://github.com/martinbonnin/TestPaper

it fails with:

    Caused by: com.esotericsoftware.kryo.KryoException: Encountered unregistered class ID: 99
    Serialization trace:
    ingredients (testpaper.mbonnin.net.testpaper.Recipe)
    mContent (io.paperdb.PaperTable)
    at com.esotericsoftware.kryo.util.DefaultClassResolver.readClass(DefaultClassResolver.java:137)
@pilgr
Copy link
Owner

pilgr commented Sep 20, 2017

What I found for now is crash happens not because of Kryo update bu because of
update de.javakaffee:kryo-serializers:0.33 -> 0.40

@pilgr
Copy link
Owner

pilgr commented Sep 21, 2017

My previous assumption was wrong. Crash happens after update com.esotericsoftware:kryo:3.0.3->4.0.0. (previously lesser kryo version didn't take effect because of transitive dependency for kryo-serializers)

@pilgr
Copy link
Owner

pilgr commented Sep 21, 2017

you were right, thanks! changing getFieldSerializerConfig().setOptimizedGenerics for existing kryo instance doesn't take effect. Using new temporary kryo object in compatibility mode solves the issue. Fix is on the way.

@pilgr pilgr self-assigned this Sep 21, 2017
@pilgr
Copy link
Owner

pilgr commented Sep 21, 2017

Fixed in 408164c
(forgot to mention in commit message)

@pilgr pilgr closed this as completed Sep 21, 2017
@martinbonnin
Copy link
Contributor Author

Thanks ! Do you know when the next release is planned ? As far as I'm concerned, the sooner, the better as I'm stuck on 1.5 with the potential crash on Android N for now.

@pilgr
Copy link
Owner

pilgr commented Sep 21, 2017 via email

@martinbonnin
Copy link
Contributor Author

Awesome, thanks !

@pilgr
Copy link
Owner

pilgr commented Sep 21, 2017 via email

@martinbonnin
Copy link
Contributor Author

Works fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants