Add support for the TFA 30.3221.20 temperature/humidity sensor #471
Conversation
| if (headerFound == HEADER_PULSE_COUNT) { | ||
| return i; // this is the first pulse/gap pair that didn't look like a header | ||
| } else { | ||
| return -headerFound; // header not yet complete - broken transmission |
There was a problem hiding this comment.
What's the need for the headerFound * -1 instead of just a -1 for errors? The same question about the -999
There was a problem hiding this comment.
it was useful during testing to know how many header packets had been found (hence the -headerFound as response). The -999 was an (albeit ugly) hack to signal that the transmission is invalid but not messing with "the other -1". I can either document the function or remove it entirely if you have an opinion about it.
| for (int i = 0; i < 40; i++) { // read 40 value-pairs from raw data | ||
| int v0 = tfa303221->raw[payloadStartIndex + (i * 2)]; | ||
| int v1 = tfa303221->raw[payloadStartIndex + (i * 2) + 1]; | ||
| if (v0 < 357 && v1 > 357) { |
There was a problem hiding this comment.
Isn't this related to the pulse lengths?
There was a problem hiding this comment.
yes, v0/v1 are pulse length pairs (shot-long or long-short).
There was a problem hiding this comment.
switched to use of a constant for 357
|
All in all it seems to be a pretty well make PR. Some questions:
|
My code for sure. For the parts I copied I need to ask the original authors. Would that be a blocker otherwise?
I went through the style guide again and I think it matches now. Let me know if you spot something missing. That said, if you have a vscode style or a linter to share I'm happy to test it myself.
I like unit testing. Let me check if I can understand how it works in C.
Sure, do you have a favourite for me to use as style template? Don't worry if not, I'll just pick one from the other TFA * ones. |
Yes, because it contains GPL parts. The only way to fix that would be to slowly remove all GPL and at least not accept new GPL stuff.
Just adapt one of the manual pages. |
|
@jtheuer Would be nice if you update your code to integrate this protocol. |
This PR adds support for the TFA Dostmann 30.3221.20 temperature/humidity sensor.
It is based on the ground work of github.com/NorthernMan54/rtl_433_ESP/blob/master/contrib/lacrosse_tx141x.c and partly inspired by github.com/RFD-FHEM/RFFHEM/blob/master/FHEM/14_SD_WS.pm.
This code runs in "production" for several weeks now. It is however only used on an ESP32 via github.com/puuu/ESPiLight. (Related PR: puuu/ESPiLight#67).
Caveat: It only implements the methods that could be used and tested on the ESP32 (namely the temperature/humidity parsing).
Todo: