-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookies.remove(name[, options]) method #98
base: master
Are you sure you want to change the base?
Conversation
An easy way to expire a cookie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good idea to me. Looks like Travis CI says there is a syntax error with the code, if you can take a look. Also please add tests for the new feature when you get a chance!
I think it doesn't like the options argument default. |
Hi @smcmurray unless it is impossible to implement without new versions, then we want to support. If it's impossible to implement your feature on old Node.js versions, then we can hold the PR for sometime in the future in which we no longer support them 👍 |
I'm not sure how to build a test with new cookies(). |
Hi @smcmurray it's no problem. We have many tests using |
An easy way to expire a cookie.