deps: handlebars@4.3.5

pillarjs · Oct 8, 2019 · d2c5b63 · d2c5b63
1 parent 8ae35b8
commit d2c5b63
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,7 +1,8 @@
 unreleased
 ==========
 
-  deps: handlebars@4.3.4
+  deps: handlebars@4.3.5
+    - Fix error object inheritance
     - Fix work-around for `constructor` blocking
 
 4.0.5 / 2019-09-27

diff --git a/lib/hbs.js b/lib/hbs.js
@@ -150,15 +150,8 @@ function middleware(filename, options, cb) {
 
   function prependFilenameToError (filename, err) {
     // prepend to the message
-    err.message = filename + ': ' + err.message
-
-    // restore error message on stack (https://github.com/wycats/handlebars.js/issues/1562)
-    if (typeof err.stack === 'string' && err.stack.indexOf(err.name + '\n') === 0 && err.stack.indexOf(err.message) === -1) {
-      Object.defineProperty(err, 'stack', {
-        configurable: true,
-        value: err.name + ': ' + err.message,
-        writable: true
-      })
+    if (typeof err.message === 'string') {
+      err.message = filename + ': ' + err.message
     }
 
     return err

diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
   "repository": "pillarjs/hbs",
   "main": "lib/hbs.js",
   "dependencies": {
-    "handlebars": "4.3.4",
+    "handlebars": "4.3.5",
     "walk": "2.3.14"
   },
   "devDependencies": {