Fix for elastic skin #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch works only for english users, I changed the regex to be less specific and moved the img between "from" and the address: And it also works with |
pimlie
requested changes
Nov 29, 2019
|
|
||
| $p['output']['from']['value'] = $this->img_status . $p['output']['from']['value']; | ||
| $p['output']['from']['html'] = true; | ||
|
|
||
| return $p; | ||
| } | ||
|
|
||
| public function message_summary($p){ | ||
| $this->populate_message_headers($GLOBALS['MESSAGE']); |
There was a problem hiding this comment.
Didnt look this up in the docs but is using $GLOBALS really required?
|
|
||
| $p['output']['from']['value'] = $this->img_status . $p['output']['from']['value']; | ||
| $p['output']['from']['html'] = true; | ||
|
|
||
| return $p; | ||
| } | ||
|
|
||
| public function message_summary($p){ | ||
| $this->populate_message_headers($GLOBALS['MESSAGE']); | ||
| return array('content' => preg_replace('/(<span>\s*)()(From)/', '$1' . $this->img_status . ' $3', $p['content'])); |
There was a problem hiding this comment.
Please have a look at the comment/regex provided by @photoninger
|
Closing this PR as support has been added in #37, thanks for your contrib though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #26, adds support for the Elastic skin.