-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MQTT pver SSL and update to attemp disconnects and extra loggin on mqtt failures #125
Conversation
Add support for a local mqtt broke that uses ssl. Allow user to add in their ca,crt file and if exists use SSL for mqtt uploads.
Thanks for this. A few additions:
|
Added new mqtt parameter to the config_template for ca.crt file location and added check for ca.crt parameter variable incase it is not there in user's config
When low disk space detected try to upload the readings to free up the disk space. On Boot sleep for 0.5 seconds at start.
Have monitored different errors from MQTT during upload after connection. In the event of an OSError or IndexError try to disconnect MQTT to see if it prevents hangs.
Added a couple more updates here, still testing to see if they work. |
If edit made in pycharm ignore .idea/ structure
Thank you for the additions. Any chance you can raise the logging change as a separate PR to this please? Makes it easier on my end to evaluate and approve the changes. |
This reverts commit c902806.
@ZodiusInfuser have reverted from here and created new pull request #128 Will also clean this pull request so it just relates to mqtt |
Corrected logging in mqtt update as missing import on error
Thanks for tidying this up. There's a few things from a code standpoint that I'd like to do, but they can be done after this is merged in 🙂 |
Specifically, turn that exception logging line into a neater function call, and correct a few typos in the comments |
Add support for a local mqtt broke that uses ssl. Allow user to add in their ca,crt file and if exists use SSL for mqtt uploads.
Relates to issue #122