Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for set_image. #188

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Add tests for set_image. #188

merged 2 commits into from
Sep 6, 2024

Conversation

Gadgetoid
Copy link
Member

@Gadgetoid Gadgetoid commented Apr 10, 2024

This change attempts to test for the Inky wHAT set_image display issue mentioned in #182 and tries to determine if the internal buffer is set correctly.

Testing

If you want to test this branch, make sure you're running in the virtual environment to which you installed Inky and run:

pip install git+https://github.com/pimoroni/inky@patch-inky-resolution-test --force-reinstall

That should replace your version of the Inky library with the experimental version on this branch!

The image is resized to the display width/height, what was this even for?
@stonehippo
Copy link

@Gadgetoid this fix works on my wHAT, since it removes the funky flipped cols and rows.

@BryanH
Copy link

BryanH commented Jul 31, 2024

Confirmed this fix works on my wHAT (examples/logo.py), however the SPI error remains:

Detected Yellow wHAT
/home/pi/.virtualenvs/pimoroni/lib/python3.11/site-packages/inky/inky.py:254: UserWarning: SPI: Cannot disable chip-select!
  warnings.warn("SPI: Cannot disable chip-select!")

/boot/firmware/config.txt contains:

[all]
dtoverlay=i2c1
dtoverlay=i2c1-pi5
dtoverlay=spi0-0cs

@pipplo
Copy link

pipplo commented Aug 15, 2024

Just posting here to confirm that it fixes the issues on the gpiod branch I was having with my inkyWhat display

@Gadgetoid Gadgetoid marked this pull request as ready for review September 6, 2024 13:48
@Gadgetoid Gadgetoid merged commit 0135ce3 into gpiod Sep 6, 2024
8 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants