Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make USB powered and battery powered Badger2040 work the same #285

Merged
merged 4 commits into from
Mar 10, 2022

Conversation

MichaelBell
Copy link
Contributor

One annoyance with the badger is difference in the behaviour of halt() between running with power connected and without.

I realised this would be simple to fix - instead of just looping forever in halt(), instead wait for a button press and then reset - this should give you exactly the same behaviour as when running from battery.

I've also included a couple of other small changes:

  • A fix to make convert.py handle images that are already black and white
  • And I hope you might indulge me and allow a change from the internal state of the Badger2040 class from private to protected, which would help me continue to use your class as a base for my LowPowerBadger.

@Gadgetoid
Copy link
Member

I'm going to be honest- I barely touched the C++ stuff outside of ripping it to pieces in order to make it work for MicroPython. T'was all very last minute, seat of my pants. As such I'm really grateful for your efforts here- thank you!

I will gladly indulge you!

@Gadgetoid Gadgetoid merged commit 36c1b46 into pimoroni:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants