added ability to replace console #49
Conversation
| self.restoreConsole = function() { | ||
| window.console = _console; | ||
| } | ||
|
|
There was a problem hiding this comment.
Your indentation's not right here, can you fix that? (Probably tabs when it should be spaces)
|
Thanks for picking this up! The build is currently failing here though, can you look at that? On top of that, we're going to need some tests for this I think, primarily because I want to quickly run them in a range of other browsers and check that this doesn't break catastrophically anywhere. In fact does this break setLevel functionality? What happens if you replace the console and then change the log level up and down? Just a bit worried because that tries to use the console object internally, and I think it might get quite confused if we've now replaced that. |
|
@pimterry Thinking about it I think it might cause more problems than it might solve. Didn't think about other functions within the library that might use it. |
|
@pimterry Ok, I have fixed the errors, and the build is now passing. I will have a look into the issues you mentioned about the plugin linking into the existing console api. |
|
Any further updates on this @VizuaaLOG? |
|
@pimterry I haven't had the time to continue looking into it. So I haven't make any more changes. |
|
It's gross but maybe simply shimming setLevel to restore/run-setLevel/replace the console each call would suffice? |
|
Sounds plausible. Do you want to try putting together a pull request to see if that does work? |
|
It's been a while on this.. does anyone still feel this would still be useful? Let me know and I will put together a pull request if so. |
|
Yes, definitely useful, if you can find a way make it work. Feel free to have a go! We will need to have some tests in place too though to finish it, and we need to make sure the solution works nicely and reliably, as in my previous comment. Don't want that to be too intimidating though. If you want to open a PR with any progress at all that'd be great, and we can go from there :-) |
|
Just reporting in that I have not had time to work on this but did a little bit of research I can share: Potential danger with changing console by calls to this binding function. I believe we can test by mocking two separate console objects and logging before and after switching between them, verifying that only the correct one is called and the incorrect one is not called each time. If that sounds satisfactory to everyone then I will hopefully get to it in the next few days. :) |
|
Been quiet for a long while now, so closing this. Feel free to bring this up to date and reopen it if you're still interested. |
This push implements two functions allowing loglevel to replace window.console but also restore it if required. I have done a manual test and both functions worked correctly.
This is to add the feature requested here: #42