Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

update incorrect pinecone quick start pathname #168

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

abpai
Copy link
Contributor

@abpai abpai commented Nov 10, 2023

Problem

Describe the purpose of this change. What problem is being solved and why?

The quick start link reference in the debug output led to a 404 page

Solution

Found the right page, I think: https://docs.pinecone.io/docs/quickstart

Type of Change

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Run canopy command without specifying the environment variable.

Copy link
Contributor

@miararoy miararoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@miararoy
Copy link
Contributor

@igiloh-pinecone waiting your approval, and ci clearance

@igiloh-pinecone
Copy link
Contributor

@igiloh-pinecone waiting your approval, and ci clearance

The fact that we need to approve every CI run is not intentional. The "heavier" CI jobs that require secrets access are anyway configured to run only in the merge queue, after a PR has been approved.
I'll fix it

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @abpai for your contribution

@igiloh-pinecone igiloh-pinecone added this pull request to the merge queue Nov 12, 2023
Merged via the queue into pinecone-io:main with commit 3461429 Nov 12, 2023
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants