This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
CLI and server bug fixes on Windows #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That created an error on Windows
Two bugs: 1. Trying to `pgrep gunicorn` on Windows, even though windows doesn't have `pgrep` and Gunicorn isn't supported on windows. 2. In windows we need to send the `CTRL_C` signal, which has a totally different implmentation behind it than GITINT
Since there is no Gunicorn on windows, it doesn't make sense to tell the users to run it
The CLI used the url `http://0.0.0.0:8000` by default, which is not supported on windows. I replaced it with `http://localhost:8000`.
What can you do...
7 tasks
Caught in PR pinecone-io#170 review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes multiple bugs when running the CLI on windows:
canopy chat) didn't work./chatendpoint, which was usingos.path.join()canopy stoptried topgrep gunicorn, even though Windows doesn't have apgrepcommand and Gunicorn isn't supported on windows./shutdownendpoint wasn't working correctly on WindowsResolves #166.
Solution
http://0.0.0.0:8000/ by default, which is not supported on windows. I replaced it withhttp://localhost:8000.CTRL_Csignal, which has a totally different implementation thanSIGINTType of Change
Test Plan
Tested manually on mac, Windows and Linux.
We need to add a proper CLI unit test (known issue)