This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Add last message query generator #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatav
approved these changes
Dec 10, 2023
igiloh-pinecone
suggested changes
Dec 10, 2023
| if len(messages) == 0: | ||
| raise ValueError("Passed chat history does not contain any messages." | ||
| " Please include at least one message in the history.") | ||
| return [Query(text=messages[-1].content)] |
There was a problem hiding this comment.
Please take the last message which is a UserMessage (message.role == 'Role.user' or isinstance()).
If you go backwards on the messages and can't find a UserMessage - then raise an error
There was a problem hiding this comment.
This sounds a bit weird to me. It's more likely that if the last message is not user message, there is something wrong in the pipeline or usage of this class, so IMO it's better to raise an error here instead of silently do something that might not be expected by the user
There was a problem hiding this comment.
I see your point @igiloh-pinecone but agree with @acatav. Maybe I can raise if the history is empty or the last message is not a user message @igiloh-pinecone wdyt?
Since Anyscale don't support function calling for now
…e_query_generator
…n LLM Otherwise it will error out
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some LLMs do not support function calls. We need a basic query generator for this kind of APIs.
Solution
Add a super basic query generator that takes the last message and returns the message as is as a query.
Type of Change
Test Plan
Added necessary unit tests.