Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Fix create config CLI command #287

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Feb 11, 2024

Problem

Current CLi command for creating config templates not working

Solution

  1. Use simple file paths from within the repo to copy config files
  2. For ease of use add a util function to write config files

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Changed the relevant tests

@acatav acatav changed the title use simple file load for template CLI command and add a load config t… Fix create config CLI command Feb 11, 2024
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatav acatav added this pull request to the merge queue Feb 13, 2024
@acatav acatav mentioned this pull request Feb 13, 2024
7 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2024
@acatav acatav added this pull request to the merge queue Feb 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2024
@acatav acatav added this pull request to the merge queue Feb 13, 2024
Merged via the queue into pinecone-io:main with commit ae69371 Feb 13, 2024
7 checks passed
@acatav acatav deleted the fix-config-loading branch February 13, 2024 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants