Review feedback

pinecone-io · Sep 13, 2023 · aff71fe · aff71fe
1 parent be84404
commit aff71fe
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/integration/data/deleteMany.test.ts b/src/integration/data/deleteMany.test.ts
@@ -26,6 +26,11 @@ describe('deleteMany', () => {
 
   test('verify deleteMany with ids', async () => {
     const recordsToUpsert = generateRecords(5, 3);
+    expect(recordsToUpsert).toHaveLength(3);
+    expect(recordsToUpsert[0].id).toEqual('0');
+    expect(recordsToUpsert[1].id).toEqual('1');
+    expect(recordsToUpsert[2].id).toEqual('2');
+
     await ns.upsert(recordsToUpsert);
 
     // Check records got upserted
@@ -61,7 +66,7 @@ describe('deleteMany', () => {
       );
     }
 
-    // Check that record 1 still exists
+    // Check that record id='1' still exists
     const fetchResult2 = await ns.fetch(['1']);
     const records2 = fetchResult2.records;
     if (records2) {

diff --git a/src/integration/test-helpers.ts b/src/integration/test-helpers.ts
@@ -63,14 +63,11 @@ export const generateRecords = (
 
 export const generateSparseValues = (dimension: number): RecordSparseValues => {
   const values: number[] = [];
-  const indecies: number[] = [];
+  const indices: number[] = [];
   for (let j = 0; j < dimension; j++) {
     values.push(Math.random());
-    indecies.push(j);
+    indices.push(j);
   }
-  const sparseValues: RecordSparseValues = {
-    indices: indecies,
-    values: values,
-  };
+  const sparseValues: RecordSparseValues = { indices, values };
   return sparseValues;
 };