Remove typebox Static<> type inference in favor of TypeScript #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We use
typebox
for runtime validation of arguments in the Node client. Currently, we're leveraging typebox'sStatic<typeof schema>
utility for generating TypeScript types out of these runtime schemas.We've noticed this doesn't play well with documentation generation, and there have been some bug reports regarding issues possibly related to typebox's generated types.
Solution
Instead of relying on the typebox utility, use our own TypeScript types which are manually aligned with existing schemas.
Type of Change
Test Plan
These are all typing changes so there shouldn't be any client code affected by these changes.
Make sure to run:
npm run lint