Check for process
existence before accessing it
#147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On some edge platforms (specifically Cloudflare Workers),
process
does not exist at all, so checking!process
isn't enough and causes a runtime error / crash.Solution
I added a
typeof process
check before anyprocess
access occurs so that the Pinecone client works on non-Node runtimes.Type of Change
Test Plan
No test changes should be necessary, as this is just a more strict
!process
check.