Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ListResponse type from generated core, add docstring for ListOptions #210

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Export ListResponse type from generated core, add docstring for ListOptions #210

merged 1 commit into from
Mar 25, 2024

Conversation

austin-denoble
Copy link
Contributor

Problem

We're not exporting the generated ListResponse type from the OpenAPI core. This is limiting for consumers when working with the client: #209

Solution

  • Export ListResponse from pinecone-generated-ts-fetch.
  • Add docstring for ListOptions type.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Non-code change (docs, etc)

Test Plan

CI unit + integration tests

@austin-denoble austin-denoble requested a review from jhamon March 25, 2024 21:33
@austin-denoble austin-denoble merged commit 55077b1 into main Mar 25, 2024
25 checks passed
@austin-denoble austin-denoble deleted the adenoble/export-list-response branch March 25, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssmith-pc ssmith-pc ssmith-pc approved these changes

@jhamon jhamon jhamon approved these changes

@haruska haruska haruska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austin-denoble @haruska @jhamon @ssmith-pc