Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sourceTag normalization to include : as an allowed character #234

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

austin-denoble
Copy link
Contributor

@austin-denoble austin-denoble commented Jun 26, 2024

Problem

We want to allow : in sourceTags that are applied to user-agent headers on network requests.

Solution

  • Update normalizeSourceTag function to allow : as an accepted character.
  • Add new unit test permutation to validate functionality.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Test locally using the TyepScript repl with PINECONE_DEBUG and PINECONE_DEBUG_CURL to monitor network traffic:
Screenshot 2024-06-26 at 7 17 05 PM


Copy link

@rohanshah18 rohanshah18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhamon jhamon self-requested a review June 27, 2024 14:11
@austin-denoble austin-denoble merged commit 23a669f into main Jun 27, 2024
33 checks passed
@austin-denoble austin-denoble deleted the adenoble/source-tag-colon-support branch June 27, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants