Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra logging from getFetch() #280

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

maxmetcalfe
Copy link
Contributor

@maxmetcalfe maxmetcalfe commented Sep 4, 2024

Problem

getFetch() contained an extra log statement which is executed every time the API is used.

Solution

Remove the log

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Ran code that accessed and interacted with Pinecone (fetched index, queried vectors)


@maxmetcalfe
Copy link
Contributor Author

fixes #254

@andrewdoro
Copy link

@aulorbe can we merge this 🥹

@trevoruptain
Copy link

+1

1 similar comment
@snlamm
Copy link

snlamm commented Sep 8, 2024

+1

@max-tano
Copy link

merge please

@harrisonlinowes
Copy link

+1 Can we please get this merged in

@aulorbe aulorbe merged commit 399803e into pinecone-io:main Sep 11, 2024
3 of 27 checks passed
@aulorbe
Copy link
Collaborator

aulorbe commented Sep 11, 2024

Apologies for the delay, all! I have been OOO. Merged! Thanks @maxmetcalfe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants