Small fix in deleteAll documentation regardning namespaces #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulorbe
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Ah sorry for missing this @kehanzhang, thank you so much for this great catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the purpose of this change. What problem is being solved and why?
Was confusing when I read the commented documentation.
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Change documentation to represent to default namespace being deleted.
Type of Change
Test Plan
Describe specific steps for validating this change.