Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix edge #53

Merged
merged 2 commits into from
May 9, 2023
Merged

Bugfix/fix edge #53

merged 2 commits into from
May 9, 2023

Conversation

rschwabco
Copy link
Contributor

Problem

process.nextTick prevents the client from working in edge environments

Solution

Commented out process.nextTick for now. This may cause text to break.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ *] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Manually testing the client.

@rschwabco rschwabco requested a review from jhamon May 5, 2023 21:49
Copy link
Collaborator

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And tests still pass. I did some light refactoring of them yesterday before having them run in CI to make sure everything was getting cleaned up between runs, maybe that helped?

@jhamon
Copy link
Collaborator

jhamon commented May 5, 2023

Seems like this will address #44

@jhamon jhamon force-pushed the bugfix/fix-edge branch from dfa2935 to 24f09e8 Compare May 9, 2023 23:29
@jhamon
Copy link
Collaborator

jhamon commented May 9, 2023

I force-pushed because I wanted to revert the commits where you'd bumped versions and stuff, since publishing is now handled by a github actions workflow.

@jhamon jhamon merged commit 7cc3cf3 into main May 9, 2023
@jhamon jhamon deleted the bugfix/fix-edge branch May 9, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants