-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterating over Ini yields "Section" type instead of "SectionIter" (2.0 - breaking change) #42
Conversation
Hi @dralley. |
fn into_iter(self) -> Self::IntoIter { | ||
IntoIter { base: self.base, keys_iterator: self.keys.into_iter() } | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiler complained about conflicting implementations
I figured as much, I can fix it without much trouble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general principle is fine though, yes? |
I think so, if we keep the parsing capabilities of |
d6360f7
to
cbf88f3
Compare
@FreeCX Apart from missing documentation and maybe some additional tests / cleanup, how does this look |
I think pretty good |
From the previous discussion here: #35
I have no expectations about this being merged quickly or anything since it's a change for 2.0, I just wanted to put this out early for review at your leisure.
I expect that the API still needs some improvement and I might have missed some things in the docs. I'll come back to it eventually.