Merge pull request #12 from MasterK0927/keshav_new_changes

Changed the Private/Incognito UI and other changes
ping-browser · Mar 30, 2024 · 5451c0b · 5451c0b
2 parents 722af55 + 3f6b15b
commit 5451c0b
Show file tree

Hide file tree

Showing 7 changed files with 2,420 additions and 152 deletions.
diff --git a/browser/brave_profile_prefs.cc b/browser/brave_profile_prefs.cc
@@ -214,8 +214,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(kBraveAutofillPrivateWindows, true);
   // appearance
   registry->RegisterBooleanPref(kShowBookmarksButton, true);
-  registry->RegisterBooleanPref(kShowSidePanelButton, true);
-  registry->RegisterBooleanPref(kLocationBarIsWide, false);
+  registry->RegisterBooleanPref(kShowSidePanelButton, false);
+  registry->RegisterBooleanPref(kLocationBarIsWide, true);
   registry->RegisterBooleanPref(kMRUCyclingEnabled, false);
   registry->RegisterBooleanPref(kTabsSearchShow, true);
   registry->RegisterBooleanPref(kTabMuteIndicatorNotClickable, false);

diff --git a/browser/resources/settings/brave_appearance_page/sidebar.html b/browser/resources/settings/brave_appearance_page/sidebar.html
@@ -1,4 +1,4 @@
-<style include="settings-shared iron-flex">
+<!-- <style include="settings-shared iron-flex">
   .border {
     border-top: var(--cr-separator-line);
     border-bottom: var(--cr-separator-line);
@@ -45,4 +45,4 @@
       no-extension-indicator>
     </controlled-radio-button>
   </settings-radio-group>
-</div>
+</div> -->
diff --git a/browser/ui/views/sidebar/sidebar_container_view.cc b/browser/ui/views/sidebar/sidebar_container_view.cc
@@ -135,7 +135,9 @@ void SidebarContainerView::Init() {
 
   AddChildViews();
   UpdateToolbarButtonVisibility();
-  SetSidebarShowOption(GetSidebarService(browser_)->GetSidebarShowOption());
+  //setting default state to never
+  SetSidebarShowOption(ShowSidebarOption::kShowNever);
+  /*SetSidebarShowOption(GetSidebarService(browser_)->GetSidebarShowOption());*/
 }
 
 void SidebarContainerView::SetSidebarOnLeft(bool sidebar_on_left) {

diff --git a/components/brave_new_tab_ui/containers/newTab/index.tsx b/components/brave_new_tab_ui/containers/newTab/index.tsx
@@ -34,7 +34,7 @@ import { MAX_GRID_SIZE } from '../../constants/new_tab_ui'
 import Settings, { TabType as SettingsTabType } from './settings'
 
 import { BraveNewsContextProvider } from '../../components/default/braveNews/customize/Context'
-import BraveNewsHint from '../../components/default/braveNews/hint'
+// import BraveNewsHint from '../../components/default/braveNews/hint'
 import SponsoredImageClickArea from '../../components/default/sponsoredImage/sponsoredImageClickArea'
 import GridWidget from './gridWidget'
 
@@ -690,7 +690,7 @@ class NewTabPage extends React.Component<Props, State> {
             </Page.Footer>
             {newTabData.showToday &&
               <Page.GridItemNavigationBraveNews>
-                <BraveNewsHint />
+                {/* <BraveNewsHint /> */} {/*Commented out to remove the Scroll for Brave News Tile*/}
               </Page.GridItemNavigationBraveNews>
             }
           </Page.Page>

diff --git a/components/brave_private_new_tab_ui/resources/page/components/search-box/index.tsx b/components/brave_private_new_tab_ui/resources/page/components/search-box/index.tsx
diff --git a/components/img/newtab/backgrounds/dylan-malval_sea-min.webp b/components/img/newtab/backgrounds/dylan-malval_sea-min.webp
diff --git a/components/resources/brave_components_strings.grd b/components/resources/brave_components_strings.grd