Rebranded the welcome page #10
Conversation
MasterK0927
commented
Mar 25, 2024
•
MasterK0927
commented
- Rebranded the welcome page.
- Added the "-j8" flag into the ninja building tool's libs file, so that "llvm out of memory" error gets resolved.
| @@ -14,10 +14,9 @@ | |||
| namespace ui { | |||
|
|
|||
| SkColor NativeTheme::GetSystemButtonPressedColor(SkColor base_color) const { | |||
| const SkColor kBraveColorBrand = SkColorSetRGB(0xfb, 0x54, 0x2b); | |||
| const SkColor kBraveColorBrand =SkColorSetRGB(0xff, 0x54, 0x2b); | |||
There was a problem hiding this comment.
what is this colour change for?
There was a problem hiding this comment.
reverted to the default buttons color, and KbraveBrand color
There was a problem hiding this comment.
revert kara hai toh ye changed nahi ana chaiye na?
There was a problem hiding this comment.
mtlb bhaiya manually change kr diya hai, jo phele tha whi color mai
There was a problem hiding this comment.
manually bhi revert hua hai toh ye change nahi ana chaiye
There was a problem hiding this comment.
okay bhaiya looking into it
There was a problem hiding this comment.
fixed it bhaiya, it was the typo
There was a problem hiding this comment.
what is this file for?
There was a problem hiding this comment.
its the logo that is being displayed on the welcome page.
There was a problem hiding this comment.
is this logo being used on the welcome page or the other one?
There was a problem hiding this comment.
it is used in components/brave_welcome_ui/components/images/index.ts
There was a problem hiding this comment.
where is this logo being used and where is brave_logo_3d@2x.webp being used?
There was a problem hiding this comment.
brave_logo_3d@2x.webp is being used in the brave_welcome_ui page
lion_logo.svg its use is still unknown but its defined in the images under brave_welcome_ui
| @@ -14,10 +14,9 @@ | |||
| namespace ui { | |||
|
|
|||
| SkColor NativeTheme::GetSystemButtonPressedColor(SkColor base_color) const { | |||
| const SkColor kBraveColorBrand = SkColorSetRGB(0xfb, 0x54, 0x2b); | |||
There was a problem hiding this comment.
remove extra changes from this file
| @@ -19,5 +19,4 @@ SkColor NativeTheme::GetSystemButtonPressedColor(SkColor base_color) const { | |||
| return color_utils::GetResultingPaintColor( | |||
| SkColorSetA(kBraveColorBrand, is_dark ? 0x2b : 0x23), base_color); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
yaar ye extra changes bhi hata do please. files ka indentation kharab nahi karte agar wahan kuch changes nahi hai toh
build/commands/lib/util.js
Outdated
| module.exports = util |
There was a problem hiding this comment.
iss file mein koi changes hi nahi rehne chaiye
