Rebranded Private Page and other changes #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MasterK0927
commented
Mar 28, 2024
MasterK0927
commented
- Rebranded the UI of Private aka Incognito Page
- Changed the background image of new tab
- Removed the "Scroll for Brave News" prompt from the New Tab page
- Changed Brave -> Ping in the strings file responsible for private tab texts
- Changed the default state of SideBar to NEVER i.e. hidden it
- Removed the SideBar customisation settings from the settings/appearance tab
- Changed the default state of Big Search bar to true
- Set the default state of ShowSideBar Button to false
There was a problem hiding this comment.
these changes were also already merged. why are they showing up again.
Try creating a branch from this repo itself instead the fork and then raise a pr
There was a problem hiding this comment.
ye ek icon delete karne se fix nahi hoga. tumhari pichli pr changes isme firse aa rahe hai. jo changes already merge ho gaye wo firse nahi ane chaiye na
There was a problem hiding this comment.
ye bhi toh last pr mein change kiya tha
| @@ -49,31 +49,31 @@ | |||
| </message> | |||
|
|
|||
| <message name="IDS_BRAVE_WELCOME_SET_DEFAULT_BUTTON_LABEL" desc="A button that sets Brave browser as default"> | |||
| Set Brave as default browser | |||
| Set Ping as default browser | |||
| @@ -7,7 +7,7 @@ import { provideStrings } from '../../../.storybook/locale' | |||
|
|
|||
| provideStrings({ | |||
| braveWelcomeTitle: 'Privacy. By Default.', | |||
| braveWelcomeDesc: 'Get Brave protection on every link you click. Just set Brave as default and browse. Privately.', | |||
| braveWelcomeDesc: 'Get Ping protection on every link you click. Just set Ping as default and browse. Privately.', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.