Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Private/Incognito UI and other changes #12

Merged
merged 1 commit into from
Mar 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions browser/brave_profile_prefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterBooleanPref(kBraveAutofillPrivateWindows, true);
// appearance
registry->RegisterBooleanPref(kShowBookmarksButton, true);
registry->RegisterBooleanPref(kShowSidePanelButton, true);
registry->RegisterBooleanPref(kLocationBarIsWide, false);
registry->RegisterBooleanPref(kShowSidePanelButton, false);
registry->RegisterBooleanPref(kLocationBarIsWide, true);
registry->RegisterBooleanPref(kMRUCyclingEnabled, false);
registry->RegisterBooleanPref(kTabsSearchShow, true);
registry->RegisterBooleanPref(kTabMuteIndicatorNotClickable, false);
Expand Down
4 changes: 2 additions & 2 deletions browser/resources/settings/brave_appearance_page/sidebar.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<style include="settings-shared iron-flex">
<!-- <style include="settings-shared iron-flex">
.border {
border-top: var(--cr-separator-line);
border-bottom: var(--cr-separator-line);
Expand Down Expand Up @@ -45,4 +45,4 @@
no-extension-indicator>
</controlled-radio-button>
</settings-radio-group>
</div>
</div> -->
4 changes: 3 additions & 1 deletion browser/ui/views/sidebar/sidebar_container_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ void SidebarContainerView::Init() {

AddChildViews();
UpdateToolbarButtonVisibility();
SetSidebarShowOption(GetSidebarService(browser_)->GetSidebarShowOption());
//setting default state to never
SetSidebarShowOption(ShowSidebarOption::kShowNever);
/*SetSidebarShowOption(GetSidebarService(browser_)->GetSidebarShowOption());*/
}

void SidebarContainerView::SetSidebarOnLeft(bool sidebar_on_left) {
Expand Down
4 changes: 2 additions & 2 deletions components/brave_new_tab_ui/containers/newTab/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { MAX_GRID_SIZE } from '../../constants/new_tab_ui'
import Settings, { TabType as SettingsTabType } from './settings'

import { BraveNewsContextProvider } from '../../components/default/braveNews/customize/Context'
import BraveNewsHint from '../../components/default/braveNews/hint'
// import BraveNewsHint from '../../components/default/braveNews/hint'
import SponsoredImageClickArea from '../../components/default/sponsoredImage/sponsoredImageClickArea'
import GridWidget from './gridWidget'

Expand Down Expand Up @@ -690,7 +690,7 @@ class NewTabPage extends React.Component<Props, State> {
</Page.Footer>
{newTabData.showToday &&
<Page.GridItemNavigationBraveNews>
<BraveNewsHint />
{/* <BraveNewsHint /> */} {/*Commented out to remove the Scroll for Brave News Tile*/}
</Page.GridItemNavigationBraveNews>
}
</Page.Page>
Expand Down

Large diffs are not rendered by default.

Binary file modified components/img/newtab/backgrounds/dylan-malval_sea-min.webp
Binary file not shown.
158 changes: 79 additions & 79 deletions components/resources/brave_components_strings.grd

Large diffs are not rendered by default.

Loading