Default Search Engine changes #15
Conversation
| @@ -25,7 +25,7 @@ namespace brave { | |||
|
|
|||
| void SetBraveAsDefaultPrivateSearchProvider(PrefService* prefs) { | |||
| auto data = TemplateURLPrepopulateData::GetPrepopulatedEngine( | |||
| prefs, TemplateURLPrepopulateData::PREPOPULATED_ENGINE_ID_BRAVE); | |||
| prefs, TemplateURLPrepopulateData::PREPOPULATED_ENGINE_ID_GOOGLE); | |||
There was a problem hiding this comment.
this id is set as brave search so is private tab using brave search again now? please check
There was a problem hiding this comment.
Yeah, forgot to change that, my bad.
There was a problem hiding this comment.
NHI bhaiya, its still the same for the pivate tab,
PREPOPULATED_ENGINE_ID_GOOGLE is google for the private tab
There was a problem hiding this comment.
ye change revert karke check karna ek baar
There was a problem hiding this comment.
checked bhaiya, with my build
There was a problem hiding this comment.
revert karke nahi chal rha kya?
There was a problem hiding this comment.
checking bhaiya
| @@ -31,4 +34,4 @@ | |||
| pref="{{prefs.brave.other_search_engines_enabled}}" | |||
| label="$i18n{otherSearchEnginesControlLabel}" | |||
| sub-label="$i18n{otherSearchEnginesControlDesc}"> | |||
| </settings-toggle-button> | |||
| </settings-toggle-button> --> | |||
There was a problem hiding this comment.
where have commented the opening tag <settings-toggle-button>
There was a problem hiding this comment.
its with the if tag
|
|
||
| <!-- commented the html structure code for the search engine page of the settings page. --> | ||
|
|
||
| <!-- <if expr="enable_extensions"> |
There was a problem hiding this comment.
if this tag is commented that wouldn't we need to comment the next line as well
There was a problem hiding this comment.
which tag bhaiya?
There was a problem hiding this comment.
iske niche wala search-toggle-button
There was a problem hiding this comment.
didnt able to understand bhaiya, please provide more detail
There was a problem hiding this comment.
Changed the default search engine from Brave Search to Google Search for both private as well as normal search.
(In the settings page under search engine tab, in normal window Default search engine selector, Learn more hyperlink is still visible as this is coming from the chromium code)