Toolbar and omnibar changes #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MasterK0927
commented
Apr 6, 2024
MasterK0927
commented
- Hid the Brave_action icons i.e. brave_shield and brave_rewards.
- Hid the Licensed photo author toggle from the background.
- Stopped the generation of License for the background image.
udaybansal19
reviewed
Apr 6, 2024
script/generate_licenses.py
Outdated
| @@ -161,36 +161,36 @@ def validated_data_field(data, field_name): | |||
| return field_value | |||
|
|
|||
|
|
|||
| def generate_backgrounds_license(preamble, backgrounds): | |||
There was a problem hiding this comment.
we dont need to comment this out if already commented below
There was a problem hiding this comment.
actually yes, but this code is not needed by us
udaybansal19
reviewed
Apr 6, 2024
| ntp_backgrounds_preamble, ntp_backgrounds)): | ||
| print(f'- {len(ntp_backgrounds)} sub-components added in ' \ | ||
| 'brave_new_tab_ui/data/LICENSE') | ||
| # ntp_backgrounds = list_ntp_backgrounds( |
There was a problem hiding this comment.
try to remove only the things not needed. if this is already removed from react then need not comment this
udaybansal19
reviewed
Apr 6, 2024
| @@ -1,4 +1,4 @@ | |||
| <!doctype html> | |||
| <!-- <!doctype html> | |||
There was a problem hiding this comment.
what is this file doing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.