Changed theme and leftover icons and strings for android #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nikhil7174
commented
May 17, 2024
•
Nikhil7174
commented
| @@ -523,7 +523,7 @@ Config.prototype.buildArgs = function () { | |||
| args.android_channel = this.channel | |||
| if (!this.isReleaseBuild()) { | |||
There was a problem hiding this comment.
This change will only reflect in non release builds
btw why is this needed and what might be impacted by changing this?
There was a problem hiding this comment.
Changed package name for all builds.
It is needed to change the package name which is also visible in ui (dowloads settings), screenshot provided above.
udaybansal19
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.