android urls, app icon, shields changes, ai rephraser #77
Conversation
| "https://basicattentiontoken.org/user-terms-of-service/"; | ||
| public static final String BRAVE_PRIVACY_POLICY = "https://brave.com/privacy/browser/#rewards"; | ||
| "https://ping-browser.com/faqs-and-help"; | ||
| public static final String BRAVE_PRIVACY_POLICY = "https://ping-browser.com/faqs-and-help"; |
There was a problem hiding this comment.
please change these urls consciously.
support urls -> https://ping-browser.com/faqs-and-help
privacy policy -> https://ping-browser.com/privacy-policy
terms of use -> https://ping-browser.com/terms-of-use-1
and check for all urls if any new ones need to be added or updated.
also check for email Ids, we will need to update any existing email ids with ours as well
| @@ -421,7 +421,7 @@ private void updateSummaries() { | |||
|
|
|||
| private void overrideChromiumPreferences() { | |||
| // Replace fragment. | |||
| // findPreference(PREF_SHIELDS_AND_PRIVACY).setFragment(BravePrivacySettings.class.getName()); | |||
| findPreference(PREF_SHIELDS_AND_PRIVACY).setFragment(BravePrivacySettings.class.getName()); | |||
There was a problem hiding this comment.
please check for any branding changes in these settings as well
| leftImg.appendChild(leftTooltip); | ||
| pillContainer.appendChild(leftImg); | ||
|
|
||
| leftImg.addEventListener('mouseover', () => { |
There was a problem hiding this comment.
tooltips should be added using css hover property instead of mouse events
| } | ||
| }); | ||
|
|
||
| // Observe changes to the DOM to detect when the text box is removed or hidden |
There was a problem hiding this comment.
also check here if the text box is resized.
In case of chatgpt I saw that the rephraser icons does not always come in the corner. it might be because of resizing of text box or some other issue
Nikhil7174
changed the title
No description provided.