rebranded welcome page #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MasterK0927
commented
Mar 24, 2024
MasterK0927
commented
- Changed the default color of all the buttons and links, its now green by default.
- Added "-j8" flag into the ninja building tool's libs file, so that "llvm out of memory" error gets resolved.
- Rebranded the ui of the welcome page.
| @@ -14,10 +14,9 @@ | |||
| namespace ui { | |||
|
|
|||
| SkColor NativeTheme::GetSystemButtonPressedColor(SkColor base_color) const { | |||
| const SkColor kBraveColorBrand = SkColorSetRGB(0xfb, 0x54, 0x2b); | |||
| const SkColor kBraveColorBrand =SkColorSetRGB(0x00, 0xFF, 0x00); | |||
There was a problem hiding this comment.
this green wasn't looking so good. lets keep it as it is for now
chromium_src/ui/gfx/color_palette.h
Outdated
| @@ -15,7 +15,7 @@ constexpr SkColor kBraveGrey800 = SkColorSetRGB(0x3b, 0x3e, 0x4f); | |||
| constexpr SkColor kBraveNeutral300 = SkColorSetRGB(0xDE, 0xE2, 0xE6); | |||
| constexpr SkColor kBraveNeutral800 = SkColorSetRGB(0x34, 0x3A, 0x40); | |||
| constexpr SkColor kBraveBlurple300 = SkColorSetRGB(0xA0, 0xA5, 0xEB); | |||
| constexpr SkColor kBraveColorBrand = SkColorSetRGB(0xfb, 0x54, 0x2b); | |||
| constexpr SkColor kBraveColorBrand = SkColorSetRGB(0x00, 0xFF, 0x00); | |||
There was a problem hiding this comment.
if this is not working then lets revert this
| @@ -74,22 +77,24 @@ function HelpImprove () { | |||
| onChange={handleMetricsReportingChange} | |||
| isChecked={isMetricsReportingEnabled} | |||
| > | |||
| {diagnosticReportsLabel.beforeTag} | |||
There was a problem hiding this comment.
lets replace them in the constants file instead of hardcoding this here
| @@ -64,7 +64,10 @@ function HelpImprove () { | |||
| <S.MainBox> | |||
| <div className="view-header-box"> | |||
| <div className="view-details"> | |||
| <h1 className="view-title">{getLocale('braveWelcomeHelpImproveBraveTitle')}</h1> | |||
| <h1 className="view-title"> | |||
| {/*removed {getLocale('braveWelcomeHelpImproveBraveTitle')}, as the source of this is unknown*/} | |||
There was a problem hiding this comment.
lets find the source of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.