gluetidb: exclude non-public indices when restoring

pingcap · Apr 2, 2020 · 723e6ec · 723e6ec
1 parent 5c280d8
commit 723e6ec
Showing 1 changed file with 20 additions and 1 deletion.
diff --git a/pkg/gluetidb/glue.go b/pkg/gluetidb/glue.go
@@ -74,7 +74,26 @@ func (gs *tidbSession) CreateDatabase(ctx context.Context, schema *model.DBInfo)
 // CreateTable implements glue.Session
 func (gs *tidbSession) CreateTable(ctx context.Context, dbName model.CIStr, table *model.TableInfo) error {
 	d := domain.GetDomain(gs.se).DDL()
-	return d.CreateTableWithInfo(gs.se, dbName, table.Clone(), ddl.OnExistIgnore, true)
+
+	// remove all non-public indices (perhaps they shouldn't be backed up in the first place)
+	n := 0
+	for _, index := range table.Indices {
+		if index.State == model.StatePublic {
+			table.Indices[n] = index
+			n++
+		}
+	}
+	table.Indices = table.Indices[:n]
+
+	// Clone() does not clone partitions yet :(
+	table = table.Clone()
+	if table.Partition != nil {
+		newPartition := *table.Partition
+		newPartition.Definitions = append([]model.PartitionDefinition{}, ...table.Partition.Definitions)
+		table.Partition = &newPartition
+	}
+
+	return d.CreateTableWithInfo(gs.se, dbName, table, ddl.OnExistIgnore, true)
 }
 
 // Close implements glue.Session