-
Notifications
You must be signed in to change notification settings - Fork 101
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
LGTM, but I think we need more tests on this fix. @fubinzh |
A Note: This optimization assumes all files only contain one table or one index. If this precondition violated, a data lost may happen. When we have data keys and index keys in the same file(for example, This defect wouldn't affect the current BR because we create backup files for each indices and data separately. But we did need to change the way we validate files. |
@YuJuncen: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
close it due to pingcap/tidb#27240 |
What problem does this PR solve?
Partially fix #1374
What is changed and how it works?
Also,
downloadSST
would find rewrite rules by file instead of region start key for now.Check List
Tests
The same case as Too many empty region after restoration of many small tables #1374, the region count reduced about 1/2.
Release note