Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Fix speed compute #1408

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Fix speed compute #1408

merged 3 commits into from
Aug 4, 2021

Conversation

joccau
Copy link
Member

@joccau joccau commented Aug 4, 2021

What problem does this PR solve?

fix issue: the average speed isn't accurate(#1405)

What is changed and how it works?

change the Calculation method for speed

Check List

Tests

  • Manual test (add detailed scripts or steps below)

command
./br backup full --pd "172.16.6.117:2379" --compression-level 3 --storage "local:///home/zak/new_br"
./br restore full --pd "172.16.6.117:2379" --storage "local:///home/zak/new_br"
log
[2021/08/04 10:03:34.913 +08:00] [INFO] [collector.go:67] ["Full backup success summary"] [total-ranges=45] [ranges-succeed=45] [ranges-failed=0] [backup-checksum=3.515718214s] [backup-fast-checksum=7.003603ms] [backup-total-ranges=58] [backup-total-regions=77] [total-take=14.017946255s] [total-kv=15463846] [total-kv-size=1.859GB] [average-speed=132.6MB/s] ["backup data size(after compressed)"=496.8MB] [BackupTS=426781599562989570]

[2021/08/04 10:06:45.055 +08:00] [INFO] [collector.go:67] ["Full restore success summary"] [total-ranges=37] [ranges-succeed=37] [ranges-failed=0] [split-region=362.373805ms] [restore-checksum=6.890396086s] [restore-ranges=29] [total-take=17.328491842s] ["restore data size(after compressed)"=496.7MB] [total-kv=15462460] [total-kv-size=1.858GB] [average-speed=107.2MB/s]

Release note

  • fix the bug that the average speed isn't accurate in backup and restore

joccau added 2 commits August 3, 2021 21:16
Try to fix the average-speed for backup/restore
remove the useless code
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2021

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Aug 4, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2021

@joccau
Copy link
Member Author

joccau commented Aug 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@joccau joccau closed this Aug 4, 2021
@joccau joccau reopened this Aug 4, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2021

@3pointer
Copy link
Collaborator

3pointer commented Aug 4, 2021

/rebuild

@YuJuncen
Copy link
Collaborator

YuJuncen commented Aug 4, 2021

/run-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 4, 2021
@YuJuncen
Copy link
Collaborator

YuJuncen commented Aug 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3c67593

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to Push cherry-picked changes in GitHub: pushing failed, output: "remote: hooks/pre-receive: 26: .: Can't open /data/gitrpcd/.app-config/.sh \nTo https://github.com/ti-chi-bot/br\n ! [remote rejected] cherry-pick-1408-to-release-4.0 -> cherry-pick-1408-to-release-4.0 (pre-receive hook declined)\nerror: failed to push some refs to 'https://github.com/ti-chi-bot/br'\n", error: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to Push cherry-picked changes in GitHub: pushing failed, output: "remote: hooks/pre-receive: 26: .: Can't open /data/gitrpcd/.app-config/.sh \nTo https://github.com/ti-chi-bot/br\n ! [remote rejected] cherry-pick-1408-to-release-5.1 -> cherry-pick-1408-to-release-5.1 (pre-receive hook declined)\nerror: failed to push some refs to 'https://github.com/ti-chi-bot/br'\n", error: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to Push cherry-picked changes in GitHub: pushing failed, output: "remote: hooks/pre-receive: 26: .: Can't open /data/gitrpcd/.app-config/.sh \nTo https://github.com/ti-chi-bot/br\n ! [remote rejected] cherry-pick-1408-to-release-5.0 -> cherry-pick-1408-to-release-5.0 (pre-receive hook declined)\nerror: failed to push some refs to 'https://github.com/ti-chi-bot/br'\n", error: exit status 1

@Mini256
Copy link
Member

Mini256 commented Aug 4, 2021

/cherry-pick release-4.0

@ti-chi-bot
Copy link
Member

@Mini256: new pull request created: #1410.

In response to this:

/cherry-pick release-4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Mini256
Copy link
Member

Mini256 commented Aug 4, 2021

/cherry-pick release-5.0

@Mini256
Copy link
Member

Mini256 commented Aug 4, 2021

/cherry-pick release-5.1

@ti-chi-bot
Copy link
Member

@Mini256: new pull request created: #1411.

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@Mini256: new pull request created: #1412.

In response to this:

/cherry-pick release-5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added a commit that referenced this pull request Sep 13, 2021
ti-chi-bot added a commit that referenced this pull request Sep 13, 2021
ti-chi-bot added a commit that referenced this pull request Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants